Add example that uses swift-java
#2
Conversation
hashing-example/hashing-lib/Tests/SwiftHashingTests/SwiftHashingTests.swift
Outdated
Show resolved
Hide resolved
swift-java-hashing-example/hashing-app/src/main/java/com/example/hashingapp/MainActivity.kt
Show resolved
Hide resolved
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
looks great to me honestly! Awesome work and let's simplify this even further in the near future (publishing the swift-java libs and making a gradle plugin)
|
Seems fine, but good to remove redundancy and do you have copyright on all images used? |
The images included are just the default Android images used when creating a new app, so I think this is fine? |
Meaning the official Android SDK for Java generated them? |
Meaning that Android Studio generated them yeah, when you create a new "empty" Android application. |
hashing-example/README.md
Outdated
|
|
||
| * **Java Development Kit (JDK)**: We recommend using JDK 21. Ensure the `JAVA_HOME` environment variable is set to your JDK installation path. | ||
| * **Swiftly**: You need to install [Swiftly](https://www.swift.org/install/) | ||
| * **Swift SDK for Android**: You need to install the [Swift Android SDK](https://github.com/swift-android-sdk/swift-android-sdk/releases) |
There was a problem hiding this comment.
Switch this to swift.org/install, if your commands work with the trunk snapshot bundles too.
finagolfin
left a comment
finagolfin
left a comment
There was a problem hiding this comment.
Thanks for cleaning up those gradlew scripts littered everywhere. Other than link nit in README, if this works fine for you locally, looks good to me.
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
lgtm, though perhaps let's rename the example to indicate that this is showing off swift-java? e.g. hashing-swift-java-example?
No description provided.