Add information on swiftmodule load times to statistics dump command #9671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@swift-ci please test and tagging @bulbazord for his review as well on this PR because it is based on his PR |
|
@swift-ci please test |
|
@swift-ci please test llvm |
adrian-prantl
approved these changes
Dec 4, 2024
adrian-prantl
left a comment
adrian-prantl
left a comment
There was a problem hiding this comment.
This seems reasonable — one thing that won't work reliably in this implementation is that you are only taking the module base name and not the submodule as key in the map, which could lead to that value being overwritten. Does that matter? Maybe not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the PR #5540 that was approved but never merged upstream.
At Meta, we make extensive use of the statistics dump command. One thing we want to track is how long each swiftmodule took to load. We've been using a version of these patches internally for a while and have found them to be useful enough to upstream.