[lldb] Give more time to test/API/multiple-debuggers #8913
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test occasionally fails on two of the busiest CI bots (asan and matrix), and we can't reproduce it locally. This leads to the hypothesis that the test is timing out (in the sense of the number of "join attempts" performed by this test's driver). This commit doubles the number of iterations performed and also does an NFC refactor of the main test loop so that it can be more easily understood.
adrian-prantl
requested changes
Jun 19, 2024
adrian-prantl
left a comment
adrian-prantl
left a comment
There was a problem hiding this comment.
Given the bots you're mentioning, did you mean to land this on llvm/llvm-project main instead?
| int count_completed_threads(int num_threads) { | ||
| int num_completed_threads = 0; | ||
| for (int i = 0; i < num_threads; i++) | ||
| if (completed_threads_array[i] == true) |
There was a problem hiding this comment.
Suggested change
| if (completed_threads_array[i] == true) | |
| if (completed_threads_array[i]) |
| int iter = 0; | ||
| while (1) | ||
| { | ||
| int max_time_to_wait = 40; // 40 iterations, or 120 seconds |
There was a problem hiding this comment.
We usually multiply all timeouts by a factor 10 when running under ASAN. A reasonably proxy for that would be if getenv("ASAN_OPTIONS") returns a nonempty string, because lit sets that environment variable.
|
Forgot to say — this looks very promising! |
|
I landed a variant of this in 869f551. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test occasionally fails on two of the busiest CI bots (asan and matrix), and we can't reproduce it locally. This leads to the hypothesis that the test is timing out (in the sense of the number of "join attempts" performed by this test's driver).
This commit doubles the number of iterations performed and also does an NFC refactor of the main test loop so that it can be more easily understood.