-
Notifications
You must be signed in to change notification settings - Fork 351
[CAS] Integrate BitstreamWriter with CAS #8800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
[CAS] Integrate BitstreamWriter with CAS #8800
Conversation
86d2330 to
8028d5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some high level comments.
8028d5d to
b03b0e4
Compare
b03b0e4 to
5984edc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a decent enough first iteration. I suggest to explore Reader a bit and then start to add more complicated use cases.
5984edc to
45b3470
Compare
45b3470 to
4bb0347
Compare
This PR begins integrating the CAS into the LLVM Bitstream file format.
BitstreamCASWriterhere. This is implemented by taking the existing code ofBitstreamWriter. Once we agree on the approach, we will have a common base class and different implementations which has CAS or the traditional file system.