Skip to content

Conversation

@SanjayMarreddi
Copy link

@SanjayMarreddi SanjayMarreddi commented May 24, 2024

This PR begins integrating the CAS into the LLVM Bitstream file format.

  • We add the draft version of BitstreamCASWriter here. This is implemented by taking the existing code of BitstreamWriter. Once we agree on the approach, we will have a common base class and different implementations which has CAS or the traditional file system.

@SanjayMarreddi SanjayMarreddi force-pushed the feature/bitstream-cas-integration branch from 86d2330 to 8028d5d Compare May 30, 2024 20:21
@SanjayMarreddi SanjayMarreddi changed the title [CAS] Add initial version of BitstreamCASSchema and BitstreamCASObject [CAS] Integrate BitstreamWriter with CAS May 30, 2024
Copy link

@cachemeifyoucan cachemeifyoucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some high level comments.

@SanjayMarreddi SanjayMarreddi force-pushed the feature/bitstream-cas-integration branch from 8028d5d to b03b0e4 Compare June 6, 2024 23:47
@SanjayMarreddi SanjayMarreddi force-pushed the feature/bitstream-cas-integration branch from b03b0e4 to 5984edc Compare June 16, 2024 15:42
Copy link

@cachemeifyoucan cachemeifyoucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a decent enough first iteration. I suggest to explore Reader a bit and then start to add more complicated use cases.

@SanjayMarreddi SanjayMarreddi force-pushed the feature/bitstream-cas-integration branch from 5984edc to 45b3470 Compare June 18, 2024 09:06
@SanjayMarreddi SanjayMarreddi force-pushed the feature/bitstream-cas-integration branch from 45b3470 to 4bb0347 Compare June 21, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants