[lldb] Add support for multipayload enums lookup from DWARF #8171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augusto2112
force-pushed
the
mpe-lldb
branch
from
430d71a to
12d3f5c
Compare
| } | ||
|
|
||
| uint32_t getContentsSizeInWords() const override { | ||
| return m_spare_bits_mask.size() / 4; |
There was a problem hiding this comment.
This could benefit from a comment. Why 4; (is this dependent on ptrsize?) is this always divisible?
There was a problem hiding this comment.
I'm using the same terminology as GenReflection for the function name here. A word in this case is 32 bits long so always divisible by 4.
| auto bit_offset = | ||
| child_die.GetAttributeValueAsUnsigned(llvm::dwarf::DW_AT_bit_offset, 0); | ||
|
|
||
| auto byte_offset = (bit_offset + 7) / 8; |
There was a problem hiding this comment.
Can you use an llvm::align function from MatchExtras.h here?
| return child_die.Tag() == llvm::dwarf::DW_TAG_APPLE_spare_bits_mask; | ||
| }); | ||
|
|
||
| if (spare_bits_mask_die_it == child_die.children().end()) |
There was a problem hiding this comment.
I think these error cases should probably all go to the dwarf log channel?
| attributes.ExtractFormValueAtIndex(0, form_value); | ||
|
|
||
| if (!form_value.IsValid()) { | ||
| if (auto *log = GetLog(LLDBLog::Types)) { |
There was a problem hiding this comment.
Dwarf instead of Types? Or maybe both?
| // similar calculation when emitting this into metadata). | ||
| llvm::APInt bits(64, form_value.Unsigned()); | ||
| auto bitsInMask = bits.getActiveBits(); | ||
| uint32_t bytesInMask = (bitsInMask + 7) / 8; |
| auto bitsInMask = bits.getActiveBits(); | ||
| uint32_t bytesInMask = (bitsInMask + 7) / 8; | ||
| auto wordsInMask = (bytesInMask + 3) / 4; | ||
| bits = bits.zextOrTrunc(wordsInMask * 32); |
| if (isSingleWord()) | ||
| return U.VAL; | ||
| assert(getActiveBits() <= 64 && "Too many bits for uint64_t"); | ||
| /* assert(getActiveBits() <= 64 && "Too many bits for uint64_t"); */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.