[CodeGen][arm4e] Don't try to initialize a class with a constant if any of its base class cannot be initialized with a constant #7799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of its base class cannot be initialized with a constant This fixes a bug where memset was called to initialize a class with a base class that has an address-discriminated field or a vtable. This happens because ConstStructBuilder::Build leaves early with an empty Elems after failing to initialize the address-discriminated field or the vtable field with a constant, which causes ConstantAggregateBuilder::buildFrom to return undef. rdar://117175834
ojhunt
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where memset was called to initialize a class with a base class that has an address-discriminated field or a vtable.
This happens because ConstStructBuilder::Build leaves early with an empty Elems after failing to initialize the address-discriminated field or the vtable field with a constant, which causes
ConstantAggregateBuilder::buildFrom to return undef.
rdar://117175834