[lldb] Fix summary for strings with non printable unicode characters #771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Swift's StringPrinterEscapingHelper incorrectly returning the first byte of the UTF-8 representation instead of the Unicode code point for non printable unicode characters. https://bugs.swift.org/browse/SR-8111
Member
|
@swift-ci test |
Author
|
This part of the Swift implementation seems to be a copy/paste adaptation of the default implementation in DataFormatters/StringPrinter.cpp which is displaying the code point for Unicode characters. Most likely a copy/paste error from the handling of non printable ASCII characters. |
Member
|
I'll wait a bit in case Michael wants to comment -- otherwise I'll merge it. Please don't hesitate to ping this PR in case I forget. |
Member
|
Thanks, I forgot about this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Swift's StringPrinterEscapingHelper incorrectly returning the
first byte of the UTF-8 representation instead of the Unicode code point
for non printable unicode characters.
https://bugs.swift.org/browse/SR-8111