[lldb] Use summary string for ObjectiveC.Selector (NFC) #7194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kastiglione
force-pushed
the
dl/lldb-Use-summary-string-for-ObjectiveC.Selector-NFC
branch
from
608bdc5 to
08bc94b
Compare
jimingham
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
The only observable difference I can tell between the old and new summaries is that you've lost the EscapeStyle being set to Swift rather than CXX. But that only matters for strings that have non-ASCII characters in them. ObjC Selectors are C identifiers so they have to be ASCII, so that shouldn't be relevant.
|
Going to add a test. |
|
@jimingham that's about what I was thinking too. |
|
If you knew that the category you were adding the summary to only supported the swift language, then you could force the EscapeStyle to swift on the summary string formatters added to it. But those formatters are currently in the "runtime synthetics" category which is both swift & ObjC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the
ObjC_Selector_SummaryProviderfunction with the equivalent summary string.