Eng/upstream candidate v1 #5222
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for ThreadSafeAllocator, which is needed for a CAS implementation, which requires thread safe allocation for data storage.
LazyAtomicPointer is a lock-free pointer that can coordinate concurrent writes to a pointer using a generator.
Implement HashMappedTrie which stores objects into a Trie based on a hash.
benlangmuir
reviewed
Aug 30, 2022
llvm/lib/CAS/InMemoryCAS.cpp
Outdated
There was a problem hiding this comment.
Looks like we have some action cache bits lingering in InMemoryCAS (and OnDiskCAS). I put up a PR to remove it on cas/main: #5228
cachemeifyoucan
force-pushed
the
eng/upstream-candidate-v1
branch
from
74241d4 to
4ec9104
Compare
cachemeifyoucan
force-pushed
the
eng/upstream-candidate-v1
branch
from
4ec9104 to
84655bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream candidate. Please provide feedback.
Few things to consider from FIXME on experimental/cas/main branch