Skip to content

[CAS] Introduce ActionCache into llvm::cas #5163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 25, 2022
Merged

[CAS] Introduce ActionCache into llvm::cas #5163

merged 5 commits into from
Aug 25, 2022
+884 −342

Conversation

@cachemeifyoucan
Copy link

@cachemeifyoucan cachemeifyoucan commented Aug 20, 2022

Introduce ActionCache which can be used together with a CAS to cache
computation results with a key.

@cachemeifyoucan
Copy link
Author

cachemeifyoucan commented Aug 20, 2022

Finish the ActionCache implementation. This is an simplified version (intentionally) from Duncan's scratch: #4715

Currently only support CASID -> CASID mapping and the key value storage is from HashValue -> HashValue. Please check interface and all the TODO in added the code for some of the concerns of initial version.

I will start to remove the ActionCache from CASDB and rename CASDB next.

@cachemeifyoucan
Copy link
Author

cachemeifyoucan commented Aug 20, 2022

@swift-ci please test

@cachemeifyoucan
Copy link
Author

cachemeifyoucan commented Aug 20, 2022

@swift-ci please test

benlangmuir
benlangmuir reviewed Aug 22, 2022
View reviewed changes
@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-ActionCache branch 2 times, most recently from e7f0fdb to e5c073f Compare August 22, 2022 21:28
@cachemeifyoucan
Copy link
Author

cachemeifyoucan commented Aug 22, 2022

@swift-ci please test

benlangmuir
benlangmuir reviewed Aug 22, 2022
View reviewed changes
akyrtzi
akyrtzi reviewed Aug 23, 2022
View reviewed changes
@cachemeifyoucan
Copy link
Author

cachemeifyoucan commented Aug 23, 2022

@swift-ci please test

@cachemeifyoucan
Copy link
Author

cachemeifyoucan commented Aug 23, 2022

@swift-ci please test

2 similar comments
@cachemeifyoucan
Copy link
Author

cachemeifyoucan commented Aug 24, 2022

@swift-ci please test

@cachemeifyoucan
Copy link
Author

cachemeifyoucan commented Aug 24, 2022

@swift-ci please test

benlangmuir
benlangmuir reviewed Aug 24, 2022
View reviewed changes
llvm/include/llvm/CAS/ActionCache.h Outdated
Copy link

@benlangmuir benlangmuir Aug 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we made this public, we could potentially avoid needing to pass both a CAS and an ActionCache everywhere. It seems like to use the cache you are already tied to using a specific CAS since otherwise the ObjectRef won't make sense. WDYT?

Copy link
Author

@cachemeifyoucan cachemeifyoucan Aug 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't really work unless we make ActionCache owns CAS, otherwise this is going to open to all kinds of life time issues.

@cachemeifyoucan
Copy link
Author

cachemeifyoucan commented Aug 25, 2022

@swift-ci please test

@cachemeifyoucan
[CAS] Introduce ActionCache into llvm::cas
33a79c4 
Introduce ActionCache which can be used together with a CAS to cache
computation results with a key.
@cachemeifyoucan
[CAS] Integrate ActionCache to all the tools and remove old API
c2c430b
@cachemeifyoucan
Address review feedback
79ee13d
@cachemeifyoucan
Change ActionCache::get to capture error state
c25e6e9 
Distinguish errors and cache misses when calling ActionCache::get
method.
@cachemeifyoucan
Copy link
Author

cachemeifyoucan commented Aug 25, 2022

@swift-ci please test

@cachemeifyoucan
Copy link
Author

cachemeifyoucan commented Aug 25, 2022

@swift-ci please test

@cachemeifyoucan
Copy link
Author

cachemeifyoucan commented Aug 25, 2022

@swift-ci please test

benlangmuir
benlangmuir approved these changes Aug 25, 2022
View reviewed changes
@cachemeifyoucan
Copy link
Author

cachemeifyoucan commented Aug 25, 2022

@swift-ci please test

@cachemeifyoucan cachemeifyoucan merged commit 815db64 into swiftlang:experimental/cas/main Aug 25, 2022
cachemeifyoucan added a commit to cachemeifyoucan/llvm-project that referenced this pull request Aug 30, 2022
@cachemeifyoucan
[CAS] Introduce ActionCache into llvm::cas (swiftlang#5163)
7e88855 
Introduce ActionCache which can be used together with a CAS to cache
computation results with a key.
cachemeifyoucan added a commit to cachemeifyoucan/llvm-project that referenced this pull request Aug 30, 2022
@cachemeifyoucan
[CAS] Introduce ActionCache into llvm::cas (swiftlang#5163)
b83e924 
Introduce ActionCache which can be used together with a CAS to cache
computation results with a key.
cachemeifyoucan added a commit that referenced this pull request Aug 30, 2022
@cachemeifyoucan
[CAS] Introduce ActionCache into llvm::cas (#5163)
e8d53f6 
Introduce ActionCache which can be used together with a CAS to cache
computation results with a key.
@kastiglione kastiglione mentioned this pull request Sep 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benlangmuir benlangmuir benlangmuir approved these changes

@jansvoboda11 jansvoboda11 Awaiting requested review from jansvoboda11

@akyrtzi akyrtzi Awaiting requested review from akyrtzi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cachemeifyoucan @akyrtzi @benlangmuir