Change the --print-cas-tree output to print the Block CAS ID instead of the BlockData CAS ID for the NestedV1 ingestion schema #4972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of the BlockData CAS ID for the NestedV1 ingestion schema
Author
|
@swift-ci please test |
cachemeifyoucan
approved these changes
Jul 18, 2022
cachemeifyoucan
left a comment
cachemeifyoucan
left a comment
There was a problem hiding this comment.
I don't think we care in general about which CASID is printed. LGTM to pick whichever works better for you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly done because with #4778 one of the changes I have made is to have a reference from the debug-info cas block to the debug-abbrev cas block. It is more useful to have the Block CAS ID instead of the BlockData CAS ID in the
--print-cas-treeoutput because then I can verify that the debug-info block has a reference to the debug-abbrev block using the--ls-node-refscommand inllvm-cas.