[lldb] Implement file-cache optimization when reading swift reflection metadata #3901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit b5cf6ba)
Differential Revision: https://reviews.llvm.org/D118265 (cherry picked from commit b414954) (cherry picked from commit ecd3b66)
Now that reading C strings go through the file-cache by default, make sure that any calls that come from LLDBMemoryReader force live memory when we can't read from the file-cache. This is the case when: - The LLDB setting marks it as disabled. - The target is 32 bits (this may be subject to change). - The address we're reading from is not one of the fake addresses we resolved in LLDBMemoryReader. (cherry picked from commit 03a0435)
If we read a real process address, try to map that back as a tagged LLDBMLLDBMemoryReader address, so further reads originating from it benefit from the file-cache optimization. (cherry picked from commit 3d63cec)
(cherry picked from commit c1a5da6)
…e optimization is enabled (cherry picked from commit b631e67)
Author
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLDB has moved to largely using Swift reflection metadata to resolving type information of variables. Currently, LLDB reads all reflection metadata from the process over many memory reads. This change allows LLDB to read almost all reflection metadata it needs from files instead of from the process. This change should significantly speed up the time LLDB takes populate Xcode’s variable view, especially when debugging an app running on a real device.