[NFC] Make getSubmoduleID assert more debuggable #3847
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's an assertion in `ASTWriter::getSubmoduleID()` that's relatively easy to hit when inputs are malformed in the right way, but doesn't really really give you any useful information about the problem when you do. Switch to `report_fatal_error()` so we can embed a module name in the message, and add some PrettyStackTraces to include useful details in this and other crashes. This change is NFC because `report_fatal_error()` is still only called in compilers built with assertions.
benlangmuir
reviewed
Jan 26, 2022
|
|
||
| for (const FrontendInputFile &FIF : getFrontendOpts().Inputs) { | ||
| std::string filename = FIF.getFile().str(); | ||
| llvm::PrettyStackTraceFormat trace("Acting on file '%s'", filename.c_str()); |
There was a problem hiding this comment.
Nit: to avoid an allocation, could you use %.* and pass in the length? It already gets copied internally, so the lifetime of what you pass in doesn't matter (although FIF.File is probably not modified here regardless).
Untested:
llvm::PrettyStackTraceFormat trace("Acting on file '%.*s'", FIF.getFile().size(), FIF.getFile().data());
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an assertion in
ASTWriter::getSubmoduleID()that's relatively easy to hit when inputs are malformed in the right way, but doesn't really really give you any useful information about the problem when you do. Switch toreport_fatal_error()so we can embed a module name in the message, and add some PrettyStackTraces to include useful details in this and other crashes.This change is NFC because
report_fatal_error()is still only called in compilers built with assertions.(I plan to merge upstream of this branch; I just wanted to get some opinions before I took the time to do that.)