[CMake] Add missing dep when building with BUILD_SHARED_LIBS #335
Conversation
|
@swift-ci please smoke test platform |
davezarzycki
force-pushed
the
fix_build_shared_libs
branch
from
c615057 to
b305abf
Compare
davezarzycki
force-pushed
the
fix_build_shared_libs
branch
from
b305abf to
f59e83e
Compare
|
@swift-ci please smoke test platform |
|
Okay, I think I did everything correctly. APINotes is an Apple only thing. I'm not sure why Apple's version of clang's Index library is different. Do we not support CI testing for |
|
I think that this should be submitted to |
|
I'm still confused about Apple's branch scheme. Why is this change wrong for EDIT – And why did you mark this pull request as being approved when the comments suggest otherwise? |
nathawes
requested review from
jkorous-apple
and removed request for
nathawes
|
@davezarzycki - you are asking the right questions! I feel the same way. My understanding, which I admit may be incorrect, is: the current swift/master branch is an integration branch based on apple/stable/20190619. Changes are applied to that branch, go through testing and if everything passes, gets merged into swift/master. The apple/master branch is tracking llvm/master I believe. As to the incorrect marking - that was a side effect of not being fully awake, sorry about the confusion. |
|
@davezarzycki It looks like this needs to be submitted to both apple/master (that merges into swift/master-next, and thus is important for Swift's master-next branch), and then cherry-picked to apple/stable/20190619 (that merges into swift/master, and thus is need for Swift's master branch). Is our branching guide document helpful: |
hyp
left a comment
hyp
left a comment
There was a problem hiding this comment.
LGTM. Please cherry-pick to apple/stable/20190619 as well.
3 participants
No description provided.