Skip to content

Disable sanity check in StoredDeclsList for SEL typedefs #3272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: stable/20210726
Choose a base branch
from
Open

Disable sanity check in StoredDeclsList for SEL typedefs #3272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion clang/include/clang/AST/DeclContextInternals.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,13 @@ class StoredDeclsList {

// FIXME: Move the assert before the single decl case when we fix the
// duplication coming from the ASTReader reading builtin types.
assert(!llvm::is_contained(getLookupResult(), D) && "Already exists!");
assert((!llvm::is_contained(getLookupResult(), D) ||
// Swift mod: Work around an issue where the SEL type is also contained twice
// in the AST constructed by the ASTImporter and SwiftDWARFImporter. See
// rdar://82037935
(D->getIdentifier() && D->getIdentifier()->isStr("SEL")))
// End Swift mod
&& "Already exists!");
// Determine if this declaration is actually a redeclaration.
for (DeclListNode *N = getAsList(); /*return in loop*/;
N = N->Rest.dyn_cast<DeclListNode *>()) {
Expand Down