Skip to content

[lldb] Restore Swift IsSymbolARuntimeThunk override #2917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 6, 2021
Merged

[lldb] Restore Swift IsSymbolARuntimeThunk override #2917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47d7569
[lldb] Restore Swift IsSymbolARuntimeThunk override
kastiglione May 5, 2021
dce0d46
add test via exposed IsSwiftThunk in python bindings
kastiglione May 6, 2021
97082e1
Revert "add test via exposed IsSwiftThunk in python bindings"
kastiglione May 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntime.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,8 @@ class SwiftLanguageRuntime : public LanguageRuntime {

void ModulesDidLoad(const ModuleList &module_list) override;

bool IsSymbolARuntimeThunk(const Symbol &symbol) override;

/// Mangling support.
/// \{
/// Use these passthrough functions rather than calling into Swift directly,
Expand Down
9 changes: 9 additions & 0 deletions lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeNames.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,6 +596,15 @@ static lldb::ThreadPlanSP GetStepThroughTrampolinePlan(Thread &thread,
return new_thread_plan_sp;
}

bool SwiftLanguageRuntime::IsSymbolARuntimeThunk(const Symbol &symbol) {
llvm::StringRef symbol_name =
symbol.GetMangled().GetMangledName().GetStringRef();
if (symbol_name.empty())
return false;
swift::Demangle::Context demangle_ctx;
return demangle_ctx.isThunkSymbol(symbol_name);
}

bool SwiftLanguageRuntime::IsSwiftMangledName(llvm::StringRef name) {
return swift::Demangle::isSwiftSymbol(name);
}
Expand Down