[lldb][swift] Ignore -- flag in swift-extra-clang-flags #2407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`--` indicates to Clang that all following arguments are file names (even when they match a Clang compiler flag). This leads to the confusion situation where LLDB users can run `settings set target.swift-extra-clang-flags -- -v` and completely break the embedded Clang instance (that now tries to open the file `-v`). Fixes rdar://58457122 (cherry picked from commit 7fd0352)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--indicates to Clang that all following arguments are file names (even whenthey match a Clang compiler flag). This leads to the confusion situation
where LLDB users can run
settings set target.swift-extra-clang-flags -- -vand completely break the embedded Clang instance (that now tries to open the
file
-v).Fixes rdar://58457122
(cherry picked from commit 7fd0352)