[Verification] Permit swifterror in arg buffer. #1894
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a swifterror was only allowed to come from either an alloca or a parameter. The async calling convention requires that the error be a field in the swift.context parameter, so here a swifterror is allowed to be a gep into the swift.context parameter as well.
Author
|
@swift-ci please test |
aschwaighofer
requested changes
Oct 1, 2020
aschwaighofer
left a comment
aschwaighofer
left a comment
There was a problem hiding this comment.
As we disussed this change is not necessary. We just need to change the frontend to emit the IR in a slightly different way (going through an alloca).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a swifterror was only allowed to come from either an alloca or a parameter. The async calling convention requires that the error be a field in the swift.context parameter, so here a swifterror is allowed to be a gep into the swift.context parameter as well.