Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lldb/source/Commands/CommandObjectBreakpoint.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -622,6 +622,14 @@ class CommandObjectBreakpointSet : public CommandObjectParsed {
result.AppendErrorWithFormat(
"Function name regular expression could not be compiled: %s",
llvm::toString(std::move(err)).c_str());
// Check if the incorrect regex looks like a globbing expression and
// warn the user about it.
if (!m_options.m_func_regexp.empty()) {
if (m_options.m_func_regexp[0] == '*' ||
m_options.m_func_regexp[0] == '?')
result.AppendWarning(
"Function name regex does not accept glob patterns.");
}
result.SetStatus(eReturnStatusFailed);
return false;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,19 @@ def test_error(self):
self.expect("breakpoint set --func-regex (", error=True,
substrs=["error: Function name regular expression could " +
"not be compiled: parentheses not balanced"])

# Point out if looks like the user provided a globbing expression.
self.expect("breakpoint set --func-regex *a", error=True,
substrs=["error: Function name regular expression could " +
"not be compiled: repetition-operator operand invalid",
"warning: Function name regex does not accept glob patterns."])
self.expect("breakpoint set --func-regex ?a", error=True,
substrs=["error: Function name regular expression could " +
"not be compiled: repetition-operator operand invalid",
"warning: Function name regex does not accept glob patterns."])
# Make sure that warning is only shown for invalid regular expressions
# that look like a globbing expression (i.e., they have a leading * or ?).
self.expect("breakpoint set --func-regex a*+", error=True, matching=False,
substrs=["warning: Function name regex does not accept glob patterns."])
self.expect("breakpoint set --func-regex a?+", error=True, matching=False,
substrs=["warning: Function name regex does not accept glob patterns."])