[BoundsSafety] Unbreak CodeGen tests likely broken by new nocreateundeforpoison attribute
#11758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deforpoison` attribute llvm#164809 adds a new attribute on various intrinsics including `llvm.sadd.with.overflow.i32` which is used in the two test cases. This patch adds the missing attributes Matching the attributes in this test is kind of silly because there's no corresponding use of `#ATTR1` in the test. If this continues to be a problem we should probably just manually remove the lines that `update_cc_test_checks.py` added.
Author
|
Landing now to upbreak CI. I can make follow up changes to this if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm#164809 adds a new attribute on various intrinsics including
llvm.sadd.with.overflow.i32which is used in the two test cases. This patch adds the missing attributesMatching the attributes in this test is kind
of silly because there's no corresponding use of
#ATTR1in the test. If this continues to be a problem we should probably just manually remove the lines thatupdate_cc_test_checks.pyadded.