Skip to content

🍒[DebugInfo] Cherry-pick Objective-C property debug-info changes to stable/21.x #11757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 6, 2025
Merged

🍒[DebugInfo] Cherry-pick Objective-C property debug-info changes to stable/21.x #11757

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f7411dc
[clang][DebugInfo][test] Convert Objective-C property test to check L…
Michael137 Oct 27, 2025
2b4ec7d
[clang][DebugInfo][test] Rename Objective-C test
Michael137 Oct 27, 2025
8948e25
[clang][DebugInfo] Make property-auto-synth.m check LLVM IR
Michael137 Oct 27, 2025
84ebb45
[clang][DebugInfo][test] Remove redundant Objective-C property test (…
Michael137 Oct 27, 2025
659aaff
[clang][DebugInfo][test] Convert Objective-C property2.m test to chec…
Michael137 Oct 27, 2025
433cd50
[clang][DebugInfo][test] Make Objective-C property5.m test check LLVM IR
Michael137 Oct 27, 2025
ea2b30b
[llvm][DebugInfo][test] Add LLVM tests for Objective-C property debug…
Michael137 Oct 29, 2025
2f6cacc
[llvm][DebugInfo][ObjC] Fix argument order of setter/getter to DIObjC…
Michael137 Oct 29, 2025
241e6ab
[llvm][test] Skip object-property.ll debug-info test on AIX
Michael137 Oct 29, 2025
c063397
[llvm][Bitcode][ObjC] Fix order of setter/getter argument to DIObjCPr…
Michael137 Oct 29, 2025
401a413
[llvm][dwarfdump] Show name of referenced DW_TAG_APPLE_property (#165…
Michael137 Oct 31, 2025
5db3ca6
[llvm][DebugInfo][ObjC] Make sure we link backing ivars to their DW_T…
Michael137 Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[llvm][DebugInfo][ObjC] Fix argument order of setter/getter to DIObjC… 
…Property constructor (llvm#165401)

Depends on:
* llvm#165373

This caused the `DW_AT_APPLE_property_(setter|getter)` to be inverted
when compiling from LLVM IR.

(cherry picked from commit dda95d9)
  • Loading branch information
@Michael137
Michael137 committed Nov 5, 2025
commit 2f6cacc6b6329fbecbb5db350f01c316bd06c227
4 changes: 2 additions & 2 deletions llvm/lib/AsmParser/LLParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6256,8 +6256,8 @@ bool LLParser::parseDIObjCProperty(MDNode *&Result, bool IsDistinct) {
#undef VISIT_MD_FIELDS

Result = GET_OR_DISTINCT(DIObjCProperty,
(Context, name.Val, file.Val, line.Val, setter.Val,
getter.Val, attributes.Val, type.Val));
(Context, name.Val, file.Val, line.Val, getter.Val,
setter.Val, attributes.Val, type.Val));
return false;
}

Expand Down
11 changes: 4 additions & 7 deletions llvm/test/DebugInfo/Generic/objc-property.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,27 +15,24 @@
; CHECK-SAME: DW_APPLE_PROPERTY_assign, DW_APPLE_PROPERTY_readwrite,
; CHECK-SAME: DW_APPLE_PROPERTY_atomic, DW_APPLE_PROPERTY_unsafe_unretained
;
; FIXME: this should have a DW_AT_APPLE_property_getter tag
; CHECK: DW_TAG_APPLE_property
; CHECK: DW_AT_APPLE_property_name ("customGetterProp")
; CHECK: DW_AT_APPLE_property_setter ("customGetter")
; CHECK: DW_AT_APPLE_property_getter ("customGetter")
; CHECK: DW_AT_APPLE_property_attribute
; CHECK-SAME: DW_APPLE_PROPERTY_getter, DW_APPLE_PROPERTY_assign, DW_APPLE_PROPERTY_readwrite,
; CHECK-SAME: DW_APPLE_PROPERTY_atomic, DW_APPLE_PROPERTY_unsafe_unretained
;
; FIXME: this should have a DW_AT_APPLE_property_setter tag
; CHECK: DW_TAG_APPLE_property
; CHECK: DW_AT_APPLE_property_name ("customSetterProp")
; CHECK: DW_AT_APPLE_property_getter ("customSetter:")
; CHECK: DW_AT_APPLE_property_setter ("customSetter:")
; CHECK: DW_AT_APPLE_property_attribute
; CHECK-SAME: DW_APPLE_PROPERTY_assign, DW_APPLE_PROPERTY_readwrite,
; CHECK-SAME: DW_APPLE_PROPERTY_setter, DW_APPLE_PROPERTY_atomic, DW_APPLE_PROPERTY_unsafe_unretained
;
; FIXME: the DW_AT_APPLE_property_(getter|setter) values are inverted
; CHECK: DW_TAG_APPLE_property
; CHECK: DW_AT_APPLE_property_name ("customAccessorsProp")
; CHECK: DW_AT_APPLE_property_getter ("customSetter:")
; CHECK: DW_AT_APPLE_property_setter ("customGetter")
; CHECK: DW_AT_APPLE_property_getter ("customGetter")
; CHECK: DW_AT_APPLE_property_setter ("customSetter:")
; CHECK: DW_AT_APPLE_property_attribute
; CHECK-SAME: DW_APPLE_PROPERTY_getter, DW_APPLE_PROPERTY_assign, DW_APPLE_PROPERTY_readwrite,
; CHECK-SAME: DW_APPLE_PROPERTY_setter, DW_APPLE_PROPERTY_atomic, DW_APPLE_PROPERTY_unsafe_unretained
Expand Down