🍒 [lldb][windows] use Windows APIs to print to the console (#149493) #11219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charles-zablit
commented
Aug 19, 2025
charles-zablit
commented
- [lldb][windows] use Windows APIs to print to the console llvm/llvm-project#149493
|
@swift-ci please test |
Michael137
approved these changes
Aug 19, 2025
|
Let's wait until llvm#149493 (comment) is resolved. |
This is a relanding of llvm#149493. The tests were failing because we were interpreting a proper file descriptor as a console file descriptor. This patch uses the Windows APIs to print to the Windows Console, through `llvm::raw_fd_ostream`. This fixes a rendering issue where the characters defined in `DiagnosticsRendering.cpp` ("╰" for instance) are not rendered properly on Windows out of the box, because the default codepage is not `utf-8`. This solution is based on [this patch downstream](https://github.com/swiftlang/swift/pull/40632/files#diff-e948e4bd7a601e3ca82d596058ccb39326459a4751470eec4d393adeaf516977R37-R38). rdar://156064500
charles-zablit
force-pushed
the
charles-zablit/lldb/fix-unicode-support-windows-to-6.2
branch
from
ab3bf80 to
92fa9d6
Compare
|
@swift-ci please test |
|
@swift-ci please test macOS |
|
@swift-ci please test windows |
|
Reopened a PR targeting 6.2.1 here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.