[clang] Place features.json in LLVM_BINARY_DIR instead of CMAKE_BINARY_DIR
#10040
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…BINARY_DIR` Even with unified build, llvm is not always the top-level project but it can be a part of a larger build. In such cases, `CMAKE_BINARY_DIR` is not the same as `LLVM_BINARY_DIR` but swift side expects `features.json` is in `LLVM_BINARY_DIR`[^1]. [1]: https://github.com/swiftlang/swift/blob/swift-DEVELOPMENT-SNAPSHOT-2025-02-14-a/lib/Option/CMakeLists.txt#L11
Member
Author
|
@swift-ci test |
Member
Author
|
@swift-ci test Windows |
Member
Author
|
@swift-ci test macOS |
1 similar comment
Member
Author
|
@swift-ci test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even with unified build, llvm is not always the top-level project but it can be a part of a larger build. In such cases,
CMAKE_BINARY_DIRis not the same asLLVM_BINARY_DIRbut swift side expectsfeatures.jsonis inLLVM_BINARY_DIR1.Footnotes
https://github.com/swiftlang/swift/blob/swift-DEVELOPMENT-SNAPSHOT-2025-02-14-a/lib/Option/CMakeLists.txt#L11 ↩