Skip to content

Add Hashable conformance to HTTPClient.Configuration.HTTPVersion #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2022
Merged

Add Hashable conformance to HTTPClient.Configuration.HTTPVersion #636

merged 2 commits into from
Oct 7, 2022

Conversation

@fabianfett
Copy link
Member

Motivation

If we want to make progress on a 2/3-tier design, we need to take the http version settings into account for pool keying.

Changes

  • Make HTTPClient.Configuration.HTTPVersion hashable

@fabianfett fabianfett requested a review from Lukasa October 7, 2022 15:06
@fabianfett fabianfett added the 🆕 semver/minor Adds new public API. label Oct 7, 2022
@fabianfett fabianfett enabled auto-merge (squash) October 7, 2022 15:14
@fabianfett fabianfett merged commit 4d69c84 into swift-server:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees

No one assigned

Labels

🆕 semver/minor Adds new public API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fabianfett @Lukasa