Make Task.logger accessible to delegate implementations outside of Package #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
6 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
FranzBusch
reviewed
May 24, 2022
| public final class Task<Response> { | ||
| /// The `EventLoop` the delegate will be executed on. | ||
| public let eventLoop: EventLoop | ||
| public let logger: Logger // We are okay to store the logger here because a Task is for only one request. |
There was a problem hiding this comment.
Can you please add a simple doc comment to this property.
felixschlegel
force-pushed
the
fs-task-logger-access-level
branch
2 times, most recently
from
e277c8d to
1e901b9
Compare
fabianfett
approved these changes
Jul 15, 2022
glbrntt
approved these changes
Jul 20, 2022
|
@swift-server-bot add to allowlist |
|
@swift-server-bot test this please |
…ckage Motivation: This change was proposed in issue [swift-server#389](swift-server#389). Users writing their own `HttpClientResponseDelegate` implementation might want to emit log messages to the `task`'s `logger`. Modifications: Changed the access level of `Task`'s `logger` property from `internal` to `public`. Result: Users can access the `logger` property of a `Task` outside of the `async-http-client`.
felixschlegel
force-pushed
the
fs-task-logger-access-level
branch
from
c15b42a to
72a12ec
Compare
|
@swift-server-bot test this please |
|
@felixschlegel thanks a lot for the patch! sorry for the delay. |
No problem 😄 Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This change was proposed in issue #389.
Users writing their own
HttpClientResponseDelegateimplementationmight want to emit log messages to the
task'slogger.Modifications:
Changed the access level of
Task'sloggerproperty frominternalto
public.Result:
Users can access the
loggerproperty of aTaskoutside of theasync-http-clientPackage.