Skip to content

Conversation

fabianfett
Copy link
Member

@fabianfett fabianfett commented Sep 28, 2021

Motivation

After #427, we now want to make sure, we can eventually remove now unused code. Some tests depend on TaskHandler, that actually test other functionality. Work that needs to be merged before #443.

Changes

  • Replicate four test that depended on TaskHandler

Result

  • Code can be removed, but tests continue to test.

@fabianfett fabianfett added the semver/none No version bump required. label Sep 28, 2021
@fabianfett fabianfett added this to the HTTP/2 support milestone Sep 28, 2021
Copy link
Collaborator

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@fabianfett
Copy link
Member Author

swift-nightly fails because of sendable requirements.

@fabianfett fabianfett merged commit d0d4598 into swift-server:main Sep 29, 2021
@fabianfett fabianfett deleted the ff-replace-test-that-depend-on-taskhandler branch September 29, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver/none No version bump required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants