Skip to content

Kill build warnings. #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2020
Merged

Kill build warnings. #283

merged 1 commit into from
Jul 16, 2020

Conversation

@Lukasa
Copy link
Collaborator

@Lukasa Lukasa commented Jul 16, 2020

Motivation:

Build warnings fail our builds.

Modifications:

  • Update minimum NIOSSL version
  • Remove the use of the now-unnecessary try statement.

Result:

No warnings!

@Lukasa
Kill build warnings.
4d6ff32 
Motivation:

Build warnings fail our builds.

Modifications:

- Update minimum NIOSSL version
- Remove the use of the now-unnecessary `try` statement.

Result:

No warnings!
@Lukasa Lukasa added the 🔨 semver/patch No public API change. label Jul 16, 2020
@Lukasa Lukasa requested a review from artemredkin July 16, 2020 16:15
@artemredkin artemredkin merged commit 8b23060 into swift-server:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artemredkin artemredkin artemredkin approved these changes

Assignees

No one assigned

Labels

🔨 semver/patch No public API change.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Lukasa @artemredkin