Remove unneeded assertion #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: assertion on activity sometimes fails but it turns out it is overly restrictive changes: - remove assertion and accept any given activity in prepareForClose
Lukasa
approved these changes
Feb 26, 2020
Motivation: There's an edge case where the connection pool won't tolerate closing connections during syncShutdown. Modification: Add test case. Result: better coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
assertion on activity sometimes fails but it turns out it is overly restrictive, if the state of an
HTTP1ConnectionProvideris already set toclosingorclosedthen this means we have nothing to do and can simply move on to the next connection provider we want to closeChanges: