fix: correct date input in Chrome #6758
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR regards the issue I raised yesterday: #6751
The below fix doesn't break #5004 - the fix to something else that seems to have added this bug.
I got no difference of tests completed before and after the change, so hopefully it didn't break anything. (Changing the second attr.node.get_dependencies() method to New Array (attr.node.dependencies) also worked for my issue, but I wanted to change as little as possible. Didn't check if it didn't break the previous bug again. If it was changed to this, this part of code would be just as the code before PR #5004, but I'm too newbie to know why this part in #5004 was as it was. Here is the link highlitghting the previous change around this place: 0dfcd19#diff-d6a6e8b36b1b88c9bd08d5bee1887bfffc7cebb2211ce45591ef59f8d2fc1111R671)
I wanted to write a test, but had no idea how to do a test that would only feature chrome, as the bug only occured there.
Instead of the test I have videos of how the problem looked before and after the commit:
Before:
https://user-images.githubusercontent.com/68644849/134407433-a9b15dba-d19b-4d0a-b576-dcfb7ce71c82.mp4
After:
https://user-images.githubusercontent.com/68644849/134407443-a5630040-db74-4563-93ef-77c5d2a7cfeb.mp4
Both of them work on code from yesterday's issue.
This is my first PR, I tried to follow the guidelines, but I might've done something wrong. If so, I apologise. I'm amazed how long looking for a small bug takes lol. Thank you guys for maintaining it, you're amazing!
Before submitting the PR, please make sure you do the following
[feat]
,[fix]
,[chore]
, or[docs]
.Tests
npm test
and lint the project withnpm run lint