Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct date input in Chrome #6758

Closed
wants to merge 2 commits into from
Closed

Conversation

Wojmis3
Copy link

@Wojmis3 Wojmis3 commented Sep 22, 2021

This PR regards the issue I raised yesterday: #6751

The below fix doesn't break #5004 - the fix to something else that seems to have added this bug.
I got no difference of tests completed before and after the change, so hopefully it didn't break anything. (Changing the second attr.node.get_dependencies() method to New Array (attr.node.dependencies) also worked for my issue, but I wanted to change as little as possible. Didn't check if it didn't break the previous bug again. If it was changed to this, this part of code would be just as the code before PR #5004, but I'm too newbie to know why this part in #5004 was as it was. Here is the link highlitghting the previous change around this place: 0dfcd19#diff-d6a6e8b36b1b88c9bd08d5bee1887bfffc7cebb2211ce45591ef59f8d2fc1111R671)

I wanted to write a test, but had no idea how to do a test that would only feature chrome, as the bug only occured there.
Instead of the test I have videos of how the problem looked before and after the commit:

Before:
https://user-images.githubusercontent.com/68644849/134407433-a9b15dba-d19b-4d0a-b576-dcfb7ce71c82.mp4
After:
https://user-images.githubusercontent.com/68644849/134407443-a5630040-db74-4563-93ef-77c5d2a7cfeb.mp4

Both of them work on code from yesterday's issue.

This is my first PR, I tried to follow the guidelines, but I might've done something wrong. If so, I apologise. I'm amazed how long looking for a small bug takes lol. Thank you guys for maintaining it, you're amazing!

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

Didn't break what sveltejs#5004 fixed, hopefully didn't break anything else - no tests changed thei results after this change.
@TylerRick
Copy link

Could we get this merged please?

@benmccann benmccann changed the title [fix] Buggy date input in chrome fix fix: correct date input in Chrome Mar 14, 2023
@baseballyama
Copy link
Member

Close this PR because 3.57.0 is fixed this issue.
https://svelte.dev/repl/cf4fdde9695049ad807dd8412c346a6e?version=3.57.0

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants