On `<select>`, don't try generating prop code until visiting attributes #591

Conduitry · 2017-05-19T02:21:12Z

Fixes #590

When visiting `<select>` elements, don't try to add props until after the (delayed) visiting of the attributes, as that's when we determine what the props should be.

codecov-io · 2017-05-19T02:25:41Z

Codecov Report

Merging #591 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #591   +/-   ##
=======================================
  Coverage   94.45%   94.45%           
=======================================
  Files          95       95           
  Lines        2779     2779           
=======================================
  Hits         2625     2625           
  Misses        154      154

Impacted Files	Coverage Δ
src/generators/dom/visitors/Element/Element.js	`98.5% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e58bd0...a3860f2. Read the comment docs.

Rich-Harris · 2017-05-21T19:20:47Z

nice 👍

Conduitry added 2 commits May 18, 2017 22:04

fix special props on <select> elements (#590)

228417e

When visiting `<select>` elements, don't try to add props until after the (delayed) visiting of the attributes, as that's when we determine what the props should be.

add unit test

a3860f2

Rich-Harris merged commit 2194de9 into master May 21, 2017

Rich-Harris deleted the gh-590 branch May 21, 2017 19:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

On `<select>`, don't try generating prop code until visiting attributes #591

On `<select>`, don't try generating prop code until visiting attributes #591

Conduitry commented May 19, 2017

codecov-io commented May 19, 2017 •

edited

Loading

Rich-Harris commented May 21, 2017

On <select>, don't try generating prop code until visiting attributes #591

On <select>, don't try generating prop code until visiting attributes #591

Conversation

Conduitry commented May 19, 2017

codecov-io commented May 19, 2017 • edited Loading

Codecov Report

Rich-Harris commented May 21, 2017

On `<select>`, don't try generating prop code until visiting attributes #591

On `<select>`, don't try generating prop code until visiting attributes #591

codecov-io commented May 19, 2017 •

edited

Loading