Skip to content

Anchor-less if and each blocks #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 25, 2017
Merged

Anchor-less if and each blocks #512

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
162281e
populate state in preprocess step, including naming DOM nodes
Rich-Harris Apr 19, 2017
d274d08
only create anchors for if blocks when necessary
Rich-Harris Apr 19, 2017
9480f34
anchor-less each blocks
Rich-Harris Apr 19, 2017
6587cbd
yield blocks never need an anchor
Rich-Harris Apr 19, 2017
4cb1578
reduce indirection
Rich-Harris Apr 19, 2017
a0284a4
Merge branch 'master' into gh-3
Conduitry Apr 19, 2017
11cf3f9
Merge branch 'master' into gh-3
Rich-Harris Apr 25, 2017
4fe20fb
sanitize element names in preprocess step
Rich-Harris Apr 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
yield blocks never need an anchor
  • Loading branch information
@Rich-Harris
Rich-Harris committed Apr 19, 2017
commit 6587cbdbac8a63fc123d5b4768e1e77ccc135da0
5 changes: 1 addition & 4 deletions src/generators/dom/visitors/YieldTag.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
export default function visitYieldTag ( generator, block, state ) {
const anchor = `yield_anchor`;
block.createAnchor( anchor, state.parentNode );

block.builders.mount.addLine(
`${block.component}._yield && ${block.component}._yield.mount( ${state.parentNode || block.target}, ${anchor} );`
`${block.component}._yield && ${block.component}._yield.mount( ${state.parentNode || block.target}, null );`
);

block.builders.destroy.addLine(
Expand Down