Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement media element bindings #496

Merged
merged 8 commits into from
Apr 19, 2017
+89 −22
Merged

Implement media element bindings #496

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
359e676
implement bind:currentTime
Rich-Harris Apr 18, 2017
1040db9
implement bind:duration and bind:paused
Rich-Harris Apr 18, 2017
a4ba3e4
reenable all tests
Rich-Harris Apr 18, 2017
14826b7
Merge branch 'window-events' into gh-406
Rich-Harris Apr 18, 2017
fffd9ff
prevent timer proliferation
Rich-Harris Apr 18, 2017
ed1ac48
prevent audio restarting when it reaches the end
Rich-Harris Apr 18, 2017
f0b6bec
dont try to test audio stuff in JSDOM
Rich-Harris Apr 18, 2017
e1a1e65
Merge branch 'master' into gh-406
Rich-Harris Apr 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
dont try to test audio stuff in JSDOM
@Rich-Harris
Rich-Harris committed Apr 18, 2017
commit f0b6bec298481ca6141a96f724eb310a395826a7
5 changes: 5 additions & 0 deletions test/runtime/samples/binding-audio-currenttime-duration/_config.js
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
export default {
// not sure if we can really test this in JSDOM. Refer to
// https://svelte.technology/repl?example=media-elements
// instead
skip: true,

test ( assert, component, target, window ) {
assert.equal( component.get( 't' ), 0 );
assert.equal( component.get( 'd' ), 0 );