Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix debugging with no dependencies #3702

Conversation

tanhauhau
Copy link
Member

@tanhauhau tanhauhau commented Oct 13, 2019

Fixes #3588

index in for loop do not depend on the array, thats' why when debugging on item change, will end up with a empty if( ).

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests tests with npm test or yarn test)

@tanhauhau tanhauhau force-pushed the tanhauhau/debugging-with-no-dependencies branch from d194512 to 4eb9aff Compare October 13, 2019 06:19
@Rich-Harris Rich-Harris merged commit 4eb9aff into sveltejs:master Oct 17, 2019
@Rich-Harris
Copy link
Member

thank you!

@tanhauhau
Copy link
Member Author

You're welcome!

@tanhauhau tanhauhau deleted the tanhauhau/debugging-with-no-dependencies branch October 17, 2019 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile error: Nested loops with index broke after 3.9.1
2 participants