update bind:this references when setting to null #3145
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2034 by using
binding_callbacks
when setting thefoo
inbind:this={foo}
tonull
as well as when setting it to an element reference. Otherwise, the invalidation has no effect.We still need to null out references before setting new ones, in order to avoid glitches when lists are reordered. This is done by unshifting to
binding_callbacks
the functions that need to run later, as those functions are run in reverse order.