Skip to content

Deconflict shared helpers with user imports #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 28, 2017
Merged

Deconflict shared helpers with user imports #306

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1655249
use compileOptions when showing failing code
Rich-Harris Feb 28, 2017
7dff587
failing test for #222
Rich-Harris Feb 28, 2017
eb44659
add generator.helper method, use it in place of generator.uses[...]
Rich-Harris Feb 28, 2017
76663f9
prevent imported names from conflicting with built-in shared helpers …
Rich-Harris Feb 28, 2017
457c126
reenable all tests
Rich-Harris Feb 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
use compileOptions when showing failing code
  • Loading branch information
@Rich-Harris
Rich-Harris committed Feb 28, 2017
commit 1655249d7a9cd9403f868d71c7c0e29b2756f3d8
2 changes: 1 addition & 1 deletion test/generate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ describe( 'generate', () => {

try {
const source = fs.readFileSync( `test/generator/${dir}/main.html`, 'utf-8' );
compiled = svelte.compile( source );
compiled = svelte.compile( source, compileOptions );
} catch ( err ) {
if ( config.compileError ) {
config.compileError( err );
Expand Down