Use css-tree to generate a proper CSS AST and use it for transformations #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the thicket of regex hacks used to transform CSS (for scoped styles) with a proper CSS parser, namely css-tree (which, after an exhaustive search, is the fastest parser and the one that generates the richest AST).
It fixes #288, and should prevent all sorts of other weird bugs from cropping up. It also paves the way for more intelligent transformations and analysis (e.g. warning on unused rules, omitting the descendant form of the transformed selector where possible, etc), but doesn't implement any of that yet.