Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the last 3 files in kebab-case to snake_case #2890

Closed
wants to merge 2 commits into from

Conversation

run1t
Copy link

@run1t run1t commented May 27, 2019

There is only 3 files left in kebab-case in the src folder, this pull request put those in snake_case like the rest of the files for consistency.

@run1t run1t force-pushed the kebak-case-to-snake-case branch from 579217a to 25a0efc Compare May 27, 2019 21:58
@run1t run1t force-pushed the kebak-case-to-snake-case branch from 25a0efc to e36cd53 Compare May 27, 2019 22:02
@markholmes
Copy link

Might be irrelevant (and I'm new to this project so I don't have a lot of context), but there are also the compile/render-dom and compile/render-ssr folders and didn't see any documentation on it.

@run1t
Copy link
Author

run1t commented May 28, 2019

yes you're right having folder names in kebab-case and file names in snake_case seems inconsitent to me. All names should follow the same cases.

But it's seems weird to use snake_case on folder name. It's not difficult to change thought, so maybe I'll try to change them to snake_case to see how it's look.

@Rich-Harris
Copy link
Member

Going to close this in favour of #3094 because of merge conflicts — thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants