Only update inputs when the value changed #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conduitry
reviewed
Aug 28, 2018
| @@ -129,14 +129,24 @@ export default class Binding extends Node { | |||
| updateDom = null; | |||
| } | |||
|
|
|||
| const dependencyArray = [...this.value.dependencies] | |||
|
|
|||
| if (dependencyArray.length === 1) { | |||
There was a problem hiding this comment.
I'm not positive that it's needed, but using quotePropIfNecessary here seems like a good idea.
There was a problem hiding this comment.
We aren't quoting change.${prop} in most areas of the app because, for the most part, you cannot reference something that needs quotes in expressions in the template. The exception is when shorthands are used, such as:
<Comp :my-shorthand-binding-var-has-dashes/>
<div class:my-class-name-shorthand-has-dashes></div>So do shorthand bindings come through here? If so, I agree, we need to quotePropIfNecessary.
There was a problem hiding this comment.
These dependency prop strings are the same ones used like ctx.${prop} a bit further down, so I felt comfortable not looking for a quote function.
|
🤘 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1699
I originally started adding new conditions to the array in
Elements.ts, but once I figured out where to get the dependencies from, it seemed to make more sense to do it inBindings.tsto keep from exposing anything more from themungemethod.I didn't add any new tests, I updated/was guided by the existing test suite. I could add a new test if someone can think of an appropriate one.