Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #14383

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Version Packages #14383

merged 1 commit into from
Nov 25, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 20, 2024

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

svelte@5.2.8

Patch Changes

  • fix: correctly prune each blocks (#14403)

  • fix: provide temporary LegacyComponentType (#14257)

  • fix: attach spread attribute events synchronously (#14387)

  • fix: ensure last empty text node correctly hydrates (#14425)

  • fix: correctly prune key blocks (#14403)

@github-actions github-actions bot force-pushed the changeset-release/main branch 3 times, most recently from 34c9379 to 372920e Compare November 22, 2024 15:23
@webJose
Copy link
Contributor

webJose commented Nov 22, 2024

Isn't the addition of a new type a minor change? Just noticing it in case someone might find this problematic. I don't. Just saying.

@github-actions github-actions bot force-pushed the changeset-release/main branch from 372920e to 1019e02 Compare November 22, 2024 19:46
@Theo-Steiner
Copy link
Contributor

Isn't the addition of a new type a minor change? Just noticing it in case someone might find this problematic. I don't. Just saying.

I assume you're talking about LegacyComponentType?
Strictly speaking what changed was just the visibility of a type ( n combination with a little rename). What was previously a private type (ComponentType) is now being exported as (LegacyComponentType) in order to fix a bug with exporting typescript declarations.
So the provide in the changeset is bad wording, it should probably have been "change visibility of LegacyComponentType.

@webJose
Copy link
Contributor

webJose commented Nov 25, 2024

I get the why it may be considered a patch: It fixes something. Still, things that change what's publicly available are always minor or major changes. But again, I don't mind and I don't think this will be an issue for anyone.

@github-actions github-actions bot force-pushed the changeset-release/main branch from 1019e02 to 05e1dc5 Compare November 25, 2024 14:47
@Rich-Harris Rich-Harris merged commit 2b5c0e7 into main Nov 25, 2024
@Rich-Harris Rich-Harris deleted the changeset-release/main branch November 25, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants