Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Object.create for each block child contexts #1422

Merged
merged 1 commit into from
May 6, 2018

Conversation

Rich-Harris
Copy link
Member

This results in slightly better performance and lower memory usage when creating large lists

@codecov-io
Copy link

codecov-io commented May 5, 2018

Codecov Report

Merging #1422 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1422   +/-   ##
=======================================
  Coverage   91.07%   91.07%           
=======================================
  Files         122      122           
  Lines        4484     4484           
  Branches     1400     1400           
=======================================
  Hits         4084     4084           
  Misses        158      158           
  Partials      242      242
Impacted Files Coverage Δ
src/compile/nodes/EachBlock.ts 97.95% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc8b0d6...d85b60a. Read the comment docs.

@Rich-Harris Rich-Harris merged commit c7c46de into master May 6, 2018
@Rich-Harris Rich-Harris deleted the each-object-create branch May 6, 2018 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants