Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape entities correctly when compiling to static HTML #1073

Merged
merged 3 commits into from
Jan 5, 2018
Merged

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Jan 5, 2018

fixes #1066

@Rich-Harris Rich-Harris changed the title failing tests for #1066 Escape entities correctly when compiling to static HTML Jan 5, 2018
@codecov-io
Copy link

Codecov Report

Merging #1073 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1073      +/-   ##
==========================================
+ Coverage   91.68%   91.68%   +<.01%     
==========================================
  Files         123      123              
  Lines        4460     4462       +2     
  Branches     1439     1439              
==========================================
+ Hits         4089     4091       +2     
  Misses        157      157              
  Partials      214      214
Impacted Files Coverage Δ
src/generators/nodes/Element.ts 95.04% <100%> (ø) ⬆️
.../generators/server-side-rendering/visitors/Text.ts 100% <100%> (ø) ⬆️
src/utils/stringify.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70ce51d...7026222. Read the comment docs.

@Rich-Harris Rich-Harris merged commit 521fd74 into master Jan 5, 2018
@Rich-Harris Rich-Harris deleted the gh-1066 branch January 5, 2018 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTML entities treated incorrectly
3 participants