Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow components without slots to have whitespace as only child #1017

Merged
merged 1 commit into from
Dec 13, 2017

Conversation

Rich-Harris
Copy link
Member

fixes #1007

@codecov-io
Copy link

codecov-io commented Dec 13, 2017

Codecov Report

Merging #1017 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1017      +/-   ##
==========================================
+ Coverage   92.08%   92.09%   +<.01%     
==========================================
  Files         115      115              
  Lines        4297     4302       +5     
  Branches     1369     1373       +4     
==========================================
+ Hits         3957     3962       +5     
  Misses        147      147              
  Partials      193      193
Impacted Files Coverage Δ
src/generators/nodes/Element.ts 94.88% <100%> (ø) ⬆️
src/generators/nodes/Text.ts 100% <100%> (ø) ⬆️
src/generators/nodes/shared/Node.ts 96.77% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76356ce...9377331. Read the comment docs.

@Conduitry
Copy link
Member

This just restores 1.46.0 behavior, right? Any thoughts on how to handle sending slots into components that don't accept them? I'm kind of torn.

@Rich-Harris Rich-Harris merged commit 05439df into master Dec 13, 2017
@Rich-Harris Rich-Harris deleted the gh-1007 branch December 13, 2017 01:35
@Rich-Harris
Copy link
Member Author

Correct. Opened a new issue about components without slots: #1020

sacrosanctic pushed a commit to sacrosanctic/svelte that referenced this pull request Dec 24, 2024
sync kit docs

Co-authored-by: Rich-Harris <1162160+Rich-Harris@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in 1.47.0 with empty default slots
3 participants