Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition animations are removed prematurely #1290

Closed
Rich-Harris opened this issue Mar 30, 2018 · 1 comment · Fixed by #1293
Closed

Transition animations are removed prematurely #1290

Rich-Harris opened this issue Mar 30, 2018 · 1 comment · Fixed by #1293

Comments

@Rich-Harris
Copy link
Member

See https://kaysercommentary.com/Resources/Crucifixion-Resurrection-Timeline.md — if you scroll up and down quickly, transitions get removed before they're finished with.

This is the offending commit — be678c6 — it should be based on name, not just __svelte. This is what happens when I write code without getting enough sleep
Rich-Harris added a commit that referenced this issue Mar 30, 2018
@Rich-Harris
only delete applicable transition animations - fixes #1290
6860d09
@Rich-Harris Rich-Harris mentioned this issue Mar 30, 2018
Merged
Rich-Harris added a commit that referenced this issue Mar 30, 2018
@Rich-Harris
Merge pull request #1293 from sveltejs/gh-1290
c943a86 
only delete applicable transition animations
@TehShrike
Copy link
Member

https://kaysercommentary.com/Resources/Crucifixion-Resurrection-Timeline.md looks buttery smooth now when scrolling quickly 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

only delete applicable transition animations sveltejs/svelte
2 participants
@TehShrike @Rich-Harris