feat: support {@attach ...}
#714
Conversation
🦋 Changeset detectedLatest commit: 74351f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Pull Request Test Coverage Report for Build 15033208451Details
💛 - Coveralls |
Try the Instant Preview in Online PlaygroundInstall the Instant Preview to Your LocalPublished Instant Preview Packages:
|
|
@ota-meshi This is my first time adding support for a new Node in the parser, so could you check if I missed anything? |
There was a problem hiding this comment.
Awesome!!! Looks almost good!
I have made two comments so could you please make some easy fixes?
Also could you please add some documentation explaining that the new node indicates {@attach}?
https://github.com/sveltejs/svelte-eslint-parser/blob/main/docs/AST.md#directives
src/parser/svelte-ast-types.ts
Outdated
| @@ -203,6 +203,12 @@ export interface AttributeShorthand extends BaseNode { | |||
| type: "AttributeShorthand"; | |||
| expression: ESTree.Identifier; | |||
| } | |||
|
|
|||
| export interface AttachTag extends BaseNode { | |||
There was a problem hiding this comment.
This file is an AST type for Svelte v4, so there is no need to add it here.
| }, | ||
| { | ||
| "type": "Punctuator", | ||
| "value": "@", |
There was a problem hiding this comment.
The @attach token is not valid. Please refer to the implementation of @const and @html 😉
There was a problem hiding this comment.
Ohh I missed this point!
see: sveltejs/svelte#15000