Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document hydratable attribute #95

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Document hydratable attribute #95

merged 1 commit into from
Feb 24, 2020

Conversation

antony
Copy link
Member

@antony antony commented Feb 3, 2020

As per sveltejs/svelte#4258 - Support hydrating head elements

As per sveltejs/svelte#4258 - Support hydrating head elements
@Conduitry
Copy link
Member

I suppose I'm of two minds about this. Options that this plugin doesn't know about (such as this one) get passed along as-is to the compiler - so, which compiler options warrant mention in this readme?

@swyxio
Copy link

swyxio commented Feb 4, 2020

I guess i would just be really explicit about the compiler options being able to be specified.. this definitely took me scanning the source code to figure out, the docs shouldve saved me from that

@antony
Copy link
Member Author

antony commented Feb 4, 2020

@Conduitry it's a good point. I guess I'm viewing it from the standpoint of a user wanting to add Svelte support to their project, I'd probably copy the example in this readme, which specifies SSR but not hydratable, and it seems from the discussion in sveltejs/svelte#4258 like the two are tied.

@Conduitry Conduitry merged commit 99eaebc into master Feb 24, 2020
@Conduitry Conduitry deleted the hydratable branch February 24, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants