-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added the block-lang
rule
#389
Conversation
🦋 Changeset detectedLatest commit: 5445433 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR!
I haven't had time to check this yet, but let me comment on the rule name.
In *.vue
, <script>
and <style>
tags are called block
.
https://vuejs.org/api/sfc-spec.html#overview
But it's probably not called block
in *.svelte
.
So I think it probably makes more sense to rename the rule.
What do you think about naming it lang-attribute
for example?
Hi, Actually, they're referred to as blocks in the svelte docs: But I'm open to renaming it :) |
Oh! Thank you! I didn't know that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you very much!
Closes #380