Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added the block-lang rule #389

Merged
merged 28 commits into from
Mar 6, 2023
Merged

feat: Added the block-lang rule #389

merged 28 commits into from
Mar 6, 2023

Conversation

marekdedic
Copy link
Contributor

@marekdedic marekdedic commented Mar 1, 2023

Closes #380

@changeset-bot
Copy link

changeset-bot bot commented Mar 1, 2023

🦋 Changeset detected

Latest commit: 5445433

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-svelte Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 1, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@marekdedic marekdedic marked this pull request as ready for review March 1, 2023 20:39
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!
I haven't had time to check this yet, but let me comment on the rule name.

In *.vue, <script> and <style> tags are called block.
https://vuejs.org/api/sfc-spec.html#overview
But it's probably not called block in *.svelte.

So I think it probably makes more sense to rename the rule.
What do you think about naming it lang-attribute for example?

@marekdedic
Copy link
Contributor Author

Hi,
you'll get to it when you'll get to it, no pressure.

Actually, they're referred to as blocks in the svelte docs:

But I'm open to renaming it :)

@ota-meshi
Copy link
Member

Oh! Thank you! I didn't know that.
Thanks to the information you gave me, I had second thoughts that the name block-lang made the most sense.

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you very much!

@ota-meshi ota-meshi merged commit 6039793 into sveltejs:main Mar 6, 2023
@marekdedic marekdedic deleted the block-lang branch March 6, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New rule: block-lang
2 participants