Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop reporting child properties in no-unused-props when the parent object itself is used #1143

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

baseballyama
Copy link
Member

close: #1142

Copy link

changeset-bot bot commented Mar 18, 2025

🦋 Changeset detected

Latest commit: 45cb3e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 18, 2025

Try the Instant Preview in Online Playground

ESLint Online Playground

Install the Instant Preview to Your Local

npm i https://pkg.pr.new/eslint-plugin-svelte@1143

Published Instant Preview Packages:

View Commit

@baseballyama baseballyama force-pushed the fix/1142 branch 2 times, most recently from 3882673 to 2a96270 Compare March 18, 2025 10:40
@baseballyama baseballyama marked this pull request as ready for review March 18, 2025 10:41
@baseballyama baseballyama changed the title fix: stop reporting child properties in no-unused-props when the parent object is used fix: stop reporting child properties in no-unused-props when the parent object itself is used Mar 18, 2025
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ota-meshi ota-meshi merged commit 138380d into main Mar 18, 2025
17 checks passed
@ota-meshi ota-meshi deleted the fix/1142 branch March 18, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: no-unused-props fails with nested object type
2 participants