Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(consistent-selector-style): not reporting class selectors used in class directives #1108

Conversation

marekdedic
Copy link
Contributor

Closes #1105

Copy link

changeset-bot bot commented Feb 26, 2025

⚠️ No Changeset found

Latest commit: dd4fb8b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 26, 2025

Try the Instant Preview in Online Playground

ESLint Online Playground

Install the Instant Preview to Your Local

npm i https://pkg.pr.new/eslint-plugin-svelte@1108

Published Instant Preview Packages:

View Commit

@marekdedic marekdedic force-pushed the consistent-selector-style-class-directive-fix branch from dd4fb8b to 1b8c92a Compare February 26, 2025 22:49
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit 976e4f0 into sveltejs:main Mar 10, 2025
17 checks passed
@marekdedic marekdedic deleted the consistent-selector-style-class-directive-fix branch March 10, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consistent-selector-style: Class names used in class: directives can't be rewritten
2 participants