Skip to content

HardwareTimer: remove use of TIMER_OUTPUT_COMPARE #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ABOSTM
Copy link
Contributor

@ABOSTM ABOSTM commented Dec 1, 2020

HardwareTimer: remove use of TIMER_OUTPUT_COMPARE

After implementation of:
stm32duino/Arduino_Core_STM32#1247
it is better to use TIMER_DISABLED instead of TIMER_OUTPUT_COMPARE
Even if TIMER_OUTPUT_COMPARE has been kept for compatibility
reason and is still working.

After implementation of:
stm32duino/Arduino_Core_STM32#1247
it is better to use TIMER_DISABLED instead of  TIMER_OUTPUT_COMPARE
Even if TIMER_OUTPUT_COMPARE has been kept for compatibility
reason and is still working.

Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
@ABOSTM ABOSTM requested a review from fpistm December 1, 2020 17:02
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpistm fpistm merged commit a71796f into stm32duino:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants