Maven #20
Closed
Maven #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Evil is not a specific field of use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've Mavenised your project for you. This makes it much easier for a growing portion of the Java community to use it.
Even better would be for it to be regularly distributed via. Maven Central; see http://maven.apache.org/guides/mini/guide-central-repository-upload.html for a guide.
My understanding is that this would require your project to be free software, though; that is, you'd have to remove your favorite clause from the license, which I guess won't be happening; a shame.
Also, the tests don't pass: Test.java:297 calls assertEquals(null, jsonobject.get("to"));, but get(String) asserts it's return value isn't null.